build: New workflow to trigger patch releases #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Gomes <[email protected]>
macedogm
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
LGTM
One point might be to enable VEX scanning based on our VEX Hub. One way to achieve this is to do similar to RKE2 scanning workflow: https://github.com/rancher/rke2/blob/f82b4c0fcfe249d8d359eeff07f092bcf9766556/.github/workflows/trivy.yaml#L52-L53 . And then enable the VEX scan with https://github.com/rancher/rke2/blob/f82b4c0fcfe249d8d359eeff07f092bcf9766556/.github/workflows/trivy.yaml#L63-L64 . Ideally you can leave TRIVY_SHOW_SUPPRESSED as false to avoid creating an issue for the situation when only false-positives were identified.
andypitcher
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.