Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release inspect #543

Merged
merged 20 commits into from
Mar 1, 2025
Merged

release inspect #543

merged 20 commits into from
Mar 1, 2025

Conversation

brooksn
Copy link
Contributor

@brooksn brooksn commented Feb 19, 2025 •
edited
Loading

  • adds a release subcommand inspect
  • adds a config key prime_registry
  • lists information about images used by a published rke2 release.
  • installs github.com/google/go-containerregistry

example

$ release inspect v1.29.9-rc1+rke2r1

image                                            oss  prime  sig  amd64  arm64  win
-----                                            ---  -----  ---  -----  -----  ---
rancher/hardened-coredns:v1.12.0-build20241126   ✓    ✓      ?    ✓      ✓      -
rancher/mirrored-library-traefik:2.11.10         ✓    ✓      ?    ✓      ✓      -

@brooksn
release inspect
a2abf38 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
--amend
d76d5ad 
Signed-off-by: Brooks Newberry <[email protected]>
briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
registry/registry.go Outdated

// Image contains information about an image in a specific registry
type Image struct {
Exists bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the bottom of the struct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields packed

briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
briandowns
briandowns reviewed Feb 19, 2025
View reviewed changes
brooksn added 14 commits February 19, 2025 13:31
@brooksn
rm debug slog, unused struct, unused interface
9668a41 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
rm boolToMark
13ba583 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
remove sprintf
20dbe1c 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
remove unused func
3dc77f4 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
remove extra func ParseReference
45a3e99 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
remove extra comments, errorf)
aa3ca67 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
replaceRegistry unit tests
fa1264e 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
rm sprintf
0d67aaf 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
remove extra readme
8773b51 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
refactoring rke2/images.go
2bfac1a 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
sort
dcb87aa 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
table|csv
eed34c0 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
summary
1671ebf 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
refactor table|csv
0d8d4ef 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
unit tests
cf95f00 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
concurrency
516f360 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
rename receiver
a157577 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn
move fields
e774777 
Signed-off-by: Brooks Newberry <[email protected]>
@brooksn brooksn merged commit 32c3dab into rancher:master Mar 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

@tashima42 tashima42 tashima42 approved these changes

@rafaelbreno rafaelbreno Awaiting requested review from rafaelbreno

@nicholasSUSE nicholasSUSE Awaiting requested review from nicholasSUSE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brooksn @briandowns @tashima42