Add a ginkgo focus check linter #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravciak
reviewed
Feb 7, 2025
valaparthvi
force-pushed
the
fit-check
branch
from
b842701 to
492eb03
Compare
thehejik
reviewed
Feb 7, 2025
…in the PR Signed-off-by: Parthvi Vala <[email protected]> Add focus for testing Signed-off-by: Parthvi Vala <[email protected]> Newline Signed-off-by: Parthvi Vala <[email protected]> Revert "Add focus for testing" This reverts commit 147732c. Update .github/workflows/focus-ginkgo-checks.yml Co-authored-by: Martin Kravec <[email protected]> Signed-off-by: Parthvi Vala <[email protected]> Fix action not failing on a successful grep Signed-off-by: Parthvi Vala <[email protected]> Add focus for testing Signed-off-by: Parthvi Vala <[email protected]> Revert "Add focus for testing" This reverts commit 492eb03. Update .github/workflows/focus-ginkgo-checks.yml Co-authored-by: Tomas Hehejik <[email protected]> Signed-off-by: Parthvi Vala <[email protected]> Revert "Revert "Add focus for testing"" This reverts commit 1fdc623. Update .github/workflows/focus-ginkgo-checks.yml Co-authored-by: Tomas Hehejik <[email protected]> Signed-off-by: Parthvi Vala <[email protected]> Revert "Revert "Revert "Add focus for testing""" This reverts commit a137238. Remove script and other minor modifications Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
fit-check
branch
from
198ca6c to
daecc81
Compare
thehejik
reviewed
Feb 10, 2025
Co-authored-by: Tomas Hehejik <[email protected]> Signed-off-by: Parthvi Vala <[email protected]> Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
fit-check
branch
from
b511e26 to
b067885
Compare
thehejik
approved these changes
Feb 10, 2025
kravciak
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR checks for focused ginkgo specs, ensuring it does not contain any specs before it is merged. The action is triggered on any changes to a PR.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #203
Checklist:
Special notes for your reviewer: