-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go version and update dependencies #43
Conversation
4f88540
to
1e08e4d
Compare
1e08e4d
to
a44d7f1
Compare
a44d7f1
to
265ffc1
Compare
…pherd Signed-off-by: Parthvi <[email protected]>
406703b
to
e645f24
Compare
Co-authored-by: Chandan Pinjani <[email protected]> Signed-off-by: Parthvi Vala <[email protected]>
@cpinjani I have rebased the branch on top of main and also reverted some changes related to upgrading k8s related pkgs. |
Sure, are the tests run and passing on these latest changes ? |
Yes, check the PR description, the 4th runs have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What does this PR do?
onsi/ginkgo
,onsi/gomega
, and other non-k8s pkgs tolatest
.k8s.io/api
,k8s.io/apimachinery
,rancher/client-go
to support k8s 1.28.Update rancher/rancher to the HEAD commit of branch release/v2.8.1.This dependency update is targeted towards moving to Go 1.20 and migrating to rancher/shepherd from rancher/rancher.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #44
Checklist:
GKE-E2EEKS-E2EAKS-E2EAKS-E2E-2EKS-E2E-2GKE-E2E-2GKE-E2E-3EKS-E2E-3AKS-E2E-3Special notes for your reviewer:
Steps(simplified) taken to update the dependency:1.20
.latest
0.28.6
(https://github.com/kubernetes/api/releases/tag/v0.28.6, https://github.com/kubernetes/apimachinery/releases/tag/v0.28.6)v1.28.6-rancher1
(https://github.com/rancher/client-go/releases/tag/v1.28.6-rancher1)go1.20.3 mod download
rancher/rancher/apis
andrancher/rancher/client
pkgs.go1.20.13 mod tidy
go1.20.13 mod vendor
Steps taken to update the dependencies:
1.20
.latest
0.28.6
(https://github.com/kubernetes/api/releases/tag/v0.28.6, https://github.com/kubernetes/apimachinery/releases/tag/v0.28.6)v1.28.6-rancher1
(https://github.com/rancher/client-go/releases/tag/v1.28.6-rancher1)go mod tidy
go mod vendor