Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE #5

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Add LICENSE #5

merged 3 commits into from
Feb 5, 2024

Conversation

valaparthvi
Copy link
Collaborator

No description provided.

@valaparthvi valaparthvi requested a review from cpinjani December 14, 2023 09:10
Copy link
Collaborator

@cpinjani cpinjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valaparthvi
Copy link
Collaborator Author

valaparthvi commented Dec 26, 2023

lgtm, can we add copyright similar to https://github.com/rancher/elemental/blob/main/tests/e2e/configure_test.go#L2

@cpinjani @juadk @ldevulder why did you feel the need to add license to every test file? Also do you copy paste the license every time you create a new file or do you have a boiler plate for it?

@@ -1,3 +1,17 @@
/*
Copyright © 2022 - 2024 SUSE LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright © 2022 - 2024 SUSE LLC
Copyright © 2023 - 2024 SUSE LLC

@valaparthvi valaparthvi merged commit d1a8297 into main Feb 5, 2024
2 checks passed
@valaparthvi valaparthvi deleted the license branch February 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants