Add K8s chart support tests for GKE #71
Conversation
valaparthvi
force-pushed
the
upgrade-e2e
branch
4 times, most recently
from
28b7e96 to
ad57a9a
Compare
valaparthvi
changed the title
valaparthvi
force-pushed
the
upgrade-e2e
branch
4 times, most recently
from
e6430f3 to
dcd5704
Compare
valaparthvi
force-pushed
the
upgrade-e2e
branch
2 times, most recently
from
03677bd to
8e30148
Compare
| filename = strings.TrimSuffix(filename, ".go") // `.` is not allowed | ||
| filename = strings.ReplaceAll(filename, "/", "-") // `/` is not allowed | ||
| filename = strings.ToLower(filename) // string must be in lowercase | ||
| fileSplit := strings.Split(specReport.FileName(), "/") // abstract the filename |
There was a problem hiding this comment.
This change was made to avoid char length errors. Max permitted limit is 63.
The label will now be something like: line51_k8s_chart_support_provisioning_test
| description: Runner template to use | ||
| default: hosted-prov-e2e-ci-runner-spot-n2-highmem-16-gl-template-v1 | ||
| type: string | ||
| k8s_upgrade_minor_version: |
There was a problem hiding this comment.
| k8s_upgrade_minor_version: | |
| k8s_version_to_test: |
There was a problem hiding this comment.
Previously it was k8s_version_to_test but that was slightly confusing since it indicates that you might have to provide a complete version, but that is not true. We only need to pass the minor version, for e.g. 1.28, the complete version will be computed programmatically.
There was a problem hiding this comment.
k8s_minor_version_to_test ?
There was a problem hiding this comment.
I have removed the GH action for now. I will add it once AKS and EKS is implemented.
valaparthvi
force-pushed
the
upgrade-e2e
branch
2 times, most recently
from
9d10a00 to
ee2c55e
Compare
Signed-off-by: Parthvi <[email protected]>
| @@ -80,6 +80,13 @@ e2e-support-matrix-importing-tests: deps ## Run the 'SupportMatrixImporting' tes | |||
| e2e-support-matrix-provisioning-tests: deps ## Run the 'SupportMatrixProvisioning' test suite for a given ${PROVIDER} | |||
| ginkgo ${STANDARD_TEST_OPTIONS} --focus "SupportMatrixProvisioning" ./hosted/${PROVIDER}/support_matrix/ | |||
|
|
|||
| e2e-k8s-chart-support-importing-tests: deps ## Run the 'K8sChartSupportImport' test suite for a given ${PROVIDER} | |||
There was a problem hiding this comment.
Running "install-k3s install-helm install-cert-manager" would also be required in CI, no ?
There was a problem hiding this comment.
Yes, but I will deal with this later when I open PR for GH action.
| }) | ||
|
|
||
| var _ = AfterEach(func() { | ||
| // The test must restore the env to its original state, so we install rancher back to its original version and uninstall the operator charts |
There was a problem hiding this comment.
Is the restore step required ?
There was a problem hiding this comment.
Yes. To restore rancher back to it's original version so that we can start a new test, and also to uninstall operator charts, otherwise the tests running in succession will not work.
| It(fmt.Sprintf("should successfully test k8s %s chart support on rancher %s", k8sUpgradedMinorVersion, rancherUpgradedVersion), func() { | ||
| commonChartSupportUpgrade(&ctx, cluster, clusterName, rancherUpgradedVersion, helpers.RancherHostname, k8sUpgradedMinorVersion) | ||
| }) | ||
|
|
There was a problem hiding this comment.
It(fmt.Sprintf("should successfully test k8s %s chart support provisioning on upgraded rancher %s", k8sUpgradedMinorVersion, rancherUpgradedVersion)
This TC will also be required to automated, can you add TODO ?
Signed-off-by: Parthvi <[email protected]>
Signed-off-by: Parthvi <[email protected]>
What does this PR do?
This PR adds tests for k8s chart support test for GKE.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes part of #49
Checklist:
Special notes for your reviewer:
Env Vars to use: