Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epinio 1.2.1 - get the bash working for our staging #286

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

andreas-kupries
Copy link
Contributor

@andreas-kupries andreas-kupries commented Sep 13, 2022

Pull Request Checklist

  • Change does not remove any existing Images or Tags in the images-list file
  • Change does not remove / overwrite exiting Images or Tags in Rancher DockerHub
  • If updating an existing entry, verify the SOURCE is still accurate and upstream hasn't been migrated to a new regitry or repo (if they've migrated, a new repo request to EIO is needed to comply with the SOURCE DESTINATION TAG pattern)
  • New entries are in format SOURCE DESTINATION TAG
  • New entries are added to the correct section of the list (sorted lexicographically)
  • New entries have a repo created in Rancher Dockerhub (where the image will be mirrored to)
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

New images (tags of existing bases):

Linked Issues

Ref: rancher/charts#1814
Ref: epinio/epinio#1248 (comment)

Additional Notes

Final Checks after the PR is merged

  • Confirm that you can pull the new images and tags from DockerHub

@andreas-kupries andreas-kupries marked this pull request as ready for review September 14, 2022 07:27
brandond
brandond previously approved these changes Sep 14, 2022
rancher/shell did not work out
the requested image is derived from SUSE's bci-micro image with the necessary tools (beyond bash) added
made to avoid library/bash with possible license complications
Copy link
Contributor

@cbron cbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will merge on monday

@cbron cbron merged commit 617f1af into rancher:master Sep 19, 2022
@andreas-kupries andreas-kupries deleted the epinio-1248-add-to-marketplace-5 branch September 20, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants