-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rancher-logging): [4.10] add priorityClassName to DS resources #31
fix(rancher-logging): [4.10] add priorityClassName to DS resources #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before your first commit here, I think we should increment the package version. Then make charts, then apply the commits that exist here.
So in order:
- Increment Rancher Logging version - in package.yaml increment the
-rancher.{num}
part - PACKAGE=rancher-logging/4.10 make charts
- Cherry pick commit 1 from this,
- PACKAGE=rancher-logging/4.10 make charts
(note cannot cherry pick commit 2 from this as mark charts results are different due to step 1 commit)
02ec3ad
to
d5bfff5
Compare
Signed-off-by: Meza <[email protected]>
Signed-off-by: Meza <[email protected]>
Signed-off-by: Meza <[email protected]>
Signed-off-by: Meza <[email protected]>
d5bfff5
to
8133fbf
Compare
Understood, made the changes in sequence as requested. Please let me know if I need to do anything else. Thanks! |
Cool - now that this is merged, you can create a new PR (or update the other one) similar what I mentioned here: rancher/charts#5212 (review) |
Will do, thanks! |
Issue:
rancher/rancher#49048 && SURE-9662
Solution
Added priorityClassName to DS resources for k3s/rke/rk2 only if value is populated in values.yaml
{{- with .Values.priorityClassName }} priorityClassName: {{ . }} {{- end }}
Added podPriorityClassName in Logging/FluentBitAgent generic templates with the option to set it in the global or fluentd/fluentbit keys.
QA Testing Considerations
Example values.yaml used for testing. Comment out the
podPriorityClassName
to testpriorityClassName: global-level-test
is passed down to all resources.