Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rancher secret key names for vSphere in secret mapper #1110

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Feb 27, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1109

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7 furkatgofurov7 marked this pull request as ready for review February 27, 2025 10:09
@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner February 27, 2025 10:09
@alexander-demicev alexander-demicev merged commit 15da041 into rancher:main Feb 27, 2025
8 checks passed
@thehejik
Copy link
Collaborator

After applying the fix the message is not visible anymore:

status:
  conditions:
    - lastTransitionTime: '2025-02-27T10:10:20Z'
      message: Updated to latest v1.12.0 version
      status: 'True'
      type: CheckLatestVersionTime
    - lastTransitionTime: '2025-02-27T10:10:20Z'
      status: 'True'
      type: LastAppliedConfigurationTime
    - lastTransitionTime: '2025-02-27T10:10:20Z'
      status: 'True'
      type: RancherCredentialsSecretMapped

Also the secret is generated properly now
image

@furkatgofurov7 furkatgofurov7 deleted the sure-9775 branch February 27, 2025 10:34
@furkatgofurov7 furkatgofurov7 added the kind/bug Something isn't working label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SURE-9775] vsphere provider and missing credentials_keys
4 participants