Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Pack of Improvements #90

Closed
wants to merge 12 commits into from
Closed

Conversation

tfuxu
Copy link
Contributor

@tfuxu tfuxu commented Jan 24, 2024

This is a pack of miscellaneous improvements and fixes I've made to refresh my Rust knowledge, and to remind myself how fun it is to fight the borrow checker :^)

This pack contains the following changes:

  • Added Adw.ToastOverlay container for use in bookmark/clipboard operations
  • Put Download and Input views in Adw.Clamp to make them width more dynamic
  • Fixed a bug in gemini library that created malformed URLs if the site redirected to relative URL location (fixes Redirects with relative URLs fail to load #91)
  • Fixed an mistake in gemini that put 10000 seconds of timeout on server response
  • Removed Pointer_* accelerators (if they were supposed to show gestures, I can add proper accelerators later)
  • Removed bottom main menu button (as in most of the app I've seen, they don't move this button to the bottom) (indirectly fixes Zoom buttons vanish when on mobile #54)
  • Made upper main menu button primary (enables F10 shortcut)

@tfuxu tfuxu changed the title Improvements pack An Pack of Improvements Jan 24, 2024
@tfuxu tfuxu changed the title An Pack of Improvements A Pack of Improvements Jan 25, 2024
@tfuxu tfuxu marked this pull request as ready for review January 25, 2024 21:26
    - remove unused `format()` in data/icons/meson.build
    - apply formatting in `tab.blp`
@ranfdev
Copy link
Owner

ranfdev commented Feb 3, 2024

I've merged everything offline, via git, instead of using the github UI. These are some great improvements, thanks!

@ranfdev ranfdev closed this Feb 3, 2024
@tfuxu tfuxu deleted the improvements-pack branch February 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirects with relative URLs fail to load Zoom buttons vanish when on mobile
2 participants