Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Polars docs #16820

Open
wants to merge 2 commits into
base: branch-24.08
Choose a base branch
from
Open

Improve Polars docs #16820

wants to merge 2 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 17, 2024

Description

This PR improves the docs by reducing the size of the Polars heading (too many words) and tightening up the writing of the docs page.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested review from a team as code owners September 17, 2024 18:51
@bdice bdice changed the base branch from branch-24.10 to branch-24.08 September 17, 2024 18:52
@bdice bdice added doc Documentation non-breaking Non-breaking change labels Sep 17, 2024
@bdice
Copy link
Contributor Author

bdice commented Sep 17, 2024 •
edited
Loading

We can target branch-24.08 or branch-24.10 with this PR (it would be merged after #16813). Reviewers, please weigh in on that decision.

galipremsagar
galipremsagar approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with merging into 24.08

quasiben
quasiben approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bdice bdice mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasiben quasiben quasiben approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@beckernick beckernick Awaiting requested review from beckernick

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

@singhmanas1 singhmanas1 Awaiting requested review from singhmanas1

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @quasiben @galipremsagar @raydouglass