Rename Contains methods (#367)

raviqqe · Feb 28, 2024 · 24d983c · 24d983c
1 parent 8ac32ae
commit 24d983c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/redirect_http_client.go b/redirect_http_client.go
@@ -43,7 +43,7 @@ func (c *redirectHttpClient) Get(u *url.URL, header http.Header) (httpResponse,
 
 		code := r.StatusCode()
 
-		if c.acceptedStatusCodes.isInSet(code) {
+		if c.acceptedStatusCodes.Contains(code) {
 			return r, nil
 		} else if code >= 300 && code <= 399 {
 			i++

diff --git a/status_code_range.go b/status_code_range.go
@@ -35,6 +35,6 @@ func parseStatusCodeRange(s string) (*statusCodeRange, error) {
 	return &statusCodeRange{cs[0], cs[1]}, nil
 }
 
-func (r statusCodeRange) isInRange(code int) bool {
+func (r statusCodeRange) Contains(code int) bool {
 	return code >= r.start && code < r.end
 }
diff --git a/status_code_range_test.go b/status_code_range_test.go
@@ -30,11 +30,11 @@ func TestParsingInvalidStatusCode(t *testing.T) {
 func TestInRangeOfStatusCode(t *testing.T) {
 	r := statusCodeRange{200, 300}
 
-	assert.False(t, r.isInRange(199))
-	assert.True(t, r.isInRange(200))
-	assert.True(t, r.isInRange(201))
+	assert.False(t, r.Contains(199))
+	assert.True(t, r.Contains(200))
+	assert.True(t, r.Contains(201))
 
-	assert.True(t, r.isInRange(298))
-	assert.True(t, r.isInRange(299))
-	assert.False(t, r.isInRange(300))
+	assert.True(t, r.Contains(298))
+	assert.True(t, r.Contains(299))
+	assert.False(t, r.Contains(300))
 }
diff --git a/status_code_set.go b/status_code_set.go
@@ -19,9 +19,9 @@ func parseStatusCodeSet(value string) (statusCodeSet, error) {
 	return rs, nil
 }
 
-func (s statusCodeSet) isInSet(code int) bool {
+func (s statusCodeSet) Contains(code int) bool {
 	for r := range s {
-		if r.isInRange(code) {
+		if r.Contains(code) {
 			return true
 		}
 	}