Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Text Shortcuts extension #1542

Merged
merged 3 commits into from
May 3, 2022
Merged

Update Text Shortcuts extension #1542

merged 3 commits into from
May 3, 2022

Conversation

koinzhang
Copy link
Contributor

Description

  • Update: Delete and Replace actions support regular expressions
  • Update: Case actions add new case conversions

Screencast

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension labels Apr 30, 2022
@koinzhang
Update Text Shortcuts extension
4ce8f3f 
- Release of Text Shortcuts version 1.1
- Update: Delete and Replace actions support regular expressions
- Update: Case action adds new case conversions
pernielsentikaer
pernielsentikaer requested changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @koinzhang

Thanks for your extension update 🔥

Something weird happens when I have a text with an emoji inside. First of call, every time I change a row in Shortcut Library a beep sound occurs and when I try camelCase to snake_case I get a crash:

CleanShot 2022-05-02 at 13 24 50@2x

The text I'm using is Hello 👋

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@koinzhang
Copy link
Contributor Author

Hi @pernielsentikaer👋. Thanks for the review.
a beep sound is a bug in the raycast Api and I have filed an issue.
As for the emoji problem, I am trying to reproduce and solve it

@koinzhang
Copy link
Contributor Author

Hi @pernielsentikaer👋. Thanks for the review.

Something weird happens when I have a text with an emoji inside. First of call, every time I change a row in Shortcut Library a beep sound occurs and when I try camelCase to snake_case I get a crash

I have fixed the bug, please keep reviewing.

@koinzhang koinzhang requested a review from pernielsentikaer May 2, 2022 13:47
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @koinzhang you might want to have a look.

@pernielsentikaer pernielsentikaer self-assigned this May 3, 2022
@pernielsentikaer pernielsentikaer merged commit cdbd7d8 into raycast:main May 3, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/koinzhang/case-word

@koinzhang koinzhang deleted the upstream/text-shortcuts branch May 10, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pernielsentikaer pernielsentikaer Awaiting requested review from pernielsentikaer

Assignees

@pernielsentikaer pernielsentikaer

Labels
extension fix / improvement Label for PRs with extension's fix improvements OP is author The OP of the PR is the author of the extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koinzhang @raycastbot @pernielsentikaer