-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tabs): Support icon-only tab #2496
base: master
Are you sure you want to change the base?
Conversation
|
✅ PR title follows Conventional Commits specification. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ba83871:
|
@@ -59,7 +59,7 @@ type TabItemProps = { | |||
/** | |||
* The label of the tab item. | |||
*/ | |||
children: React.ReactNode; | |||
children?: React.ReactNode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add accessibilityLabel prop
Description
This pr -
add support for icons only
fixes alignment of icon
fixes border radius of tabs
removes divider from tablist
updates border color
updates padding
updates type
Changes
Additional Information
Component Checklist