Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): adjust icon vertical margins for better alignment #2503

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harshcut
Copy link
Member

@harshcut harshcut commented Jan 28, 2025

Description

Fixes arrow-right icon alignment issues for DatePicker with range selection.

Changes

  • align arrow from end, since the top margin will vary based on label
  • adjust bottom margin values

Additional Information

Screen.Recording.2025-01-28.at.3.50.28.PM.mov

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: b30d627

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 28, 2025

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Jan 28, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b30d627:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
DatePicker 86.982 86.953 -0.029 KB
Drawer, DrawerBody, DrawerHeader, drawerPadding 17.498 17.497 -0.001 KB

Generated by 🚫 dangerJS against b30d627

@saurabhdaware
Copy link
Member

Heya! We've just been a little busy with FTX tasks. Will try to review this by tomorrow. There were some edge cases with the DatePicker icon so just need to test them out once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants