fix: prevent duplicate tag addition #2540
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TaggedInput
, added a check to avoid duplicate tag additiononChange
will be called fromuseControllableState
hook, wrapped theonTagChange
for controlled component insideelse
branch to avoid getting called twice for uncontrolled componentChanges
Current behaviour:
TaggedInput
, thekey
prop is constructed for eachtag
using key={${tagName}-${tagIndex}
}isTagVisible
prop value as false and few other duplicated tags as non-removableScreen.Recording.2025-02-13.at.16.47.21.mov
Changes made:
onTagChange
invocation part insideelse
branch to avoid getting called twice incase ofuncontrolled
tagged input as it will be called once throughuseControllableState
hookScreen.Recording.2025-02-13.at.16.51.52.mov
Kindly suggest whether we need to prevent the duplicate tag addition or do we need to remove the already existing tag of same input value on hitting [Enter]
Additional Information
Component Checklist