Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize expandIcon rerender #746

Merged
merged 4 commits into from
Feb 13, 2025
+18 −11
Merged

perf: Optimize expandIcon rerender #746

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2a450f
perf: Optimize expandIcon rerender
wanpan11 Feb 13, 2025
63a0a92
Update src/SubMenu/index.tsx
wanpan11 Feb 13, 2025
869ad9f
perf: update
wanpan11 Feb 13, 2025
3525cb0
perf: update
wanpan11 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/SubMenu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,23 @@ const InternalSubMenu = React.forwardRef<HTMLLIElement, SubMenuProps>(
// =============================== Render ===============================
const popupId = domDataId && `${domDataId}-popup`;

const expandIconNode = React.useMemo(
() => (
<Icon
icon={mode !== 'horizontal' ? mergedExpandIcon : undefined}
props={{
...props,
isOpen: open,
// [Legacy] Not sure why need this mark
isSubMenu: true,
}}
>
<i className={`${subMenuPrefixCls}-arrow`} />
</Icon>
),
[mode, mergedExpandIcon, props, open, subMenuPrefixCls],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props 每次应该都是新的，所以这个 expandIcon 还是会每次都调用。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props 每次应该都是新的，所以这个 expandIcon 还是会每次都调用。

我试过了 不会重复调用了
image

);

// >>>>> Title
let titleNode: React.ReactElement = (
<div
Expand All @@ -248,17 +265,7 @@ const InternalSubMenu = React.forwardRef<HTMLLIElement, SubMenuProps>(
{title}

{/* Only non-horizontal mode shows the icon */}
<Icon
icon={mode !== 'horizontal' ? mergedExpandIcon : undefined}
props={{
...props,
isOpen: open,
// [Legacy] Not sure why need this mark
isSubMenu: true,
}}
>
<i className={`${subMenuPrefixCls}-arrow`} />
</Icon>
{expandIconNode}
</div>
);

Expand Down
Loading