Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve native_module.gradle for certain custom project setups #2341

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: improve native_module.gradle for certain custom project setups #2341

wants to merge 5 commits into from

Commits on Mar 21, 2024

  1. feat: improve native_module.gradle usage 

    This change include the ability for project to set their own custom path to the actual folder which contains the react-native project. 

Given we have a consumer app which contains an android project but not actually react-native with the exception of the react-native gradle plugin, the current integration would lead to bunch of build failures. This is because the native_modules.gradle integration assumes that the react native project will be at the same some spot as the gradle root project location.

This change is backwards compatible and won't break any templates or existing projects.
    @AlexanderEggers
    AlexanderEggers committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b78ed48 View commit details
    Browse the repository at this point in the history

  2. feat: simplify applyNativeModulesAppBuildGradle to avoid needing anot… 

    …her arg
    @AlexanderEggers
    AlexanderEggers committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b5ee6c8 View commit details
    Browse the repository at this point in the history

  3. fix: add missing providers arg

    @AlexanderEggers
    AlexanderEggers committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0b13d21 View commit details
    Browse the repository at this point in the history

  4. chore: tweaking code

    @AlexanderEggers
    AlexanderEggers committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    789e3b9 View commit details
    Browse the repository at this point in the history

  5. chore: simplifying code 

    Instead of parsing a path, I changed the signature to pass a file object instead.
    @AlexanderEggers
    AlexanderEggers committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    8e9c277 View commit details
    Browse the repository at this point in the history