-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce version cloning #1208
base: master
Are you sure you want to change the base?
Reduce version cloning #1208
Conversation
Be careful with lastSeen variable, that might get GCed and reused. It might be better to use incremental ids |
Here are some stats for your PR:
Please find your performance results at https://rir-benchmarks.prl.fit.cvut.cz/diff?job_ids[]=2443680603&job_ids[]=2427588749&selection=all |
Here are some stats for your PR:
Please find your performance results at https://rir-benchmarks.prl.fit.cvut.cz/diff?job_ids[]=2468496070&job_ids[]=2467128976&selection=all |
It tries to avoid the cloning of versions and applies modifications in-place. Added some flags to track references to versions and catch simple cases