Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce version cloning #1208

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Reduce version cloning #1208

wants to merge 15 commits into from

Conversation

skrynski
Copy link
Collaborator

@skrynski skrynski commented May 4, 2022

It tries to avoid the cloning of versions and applies modifications in-place. Added some flags to track references to versions and catch simple cases

@skrynski
Copy link
Collaborator Author

Be careful with lastSeen variable, that might get GCed and reused. It might be better to use incremental ids

@o-
Copy link
Contributor

o- commented May 12, 2022

Here are some stats for your PR:

  • WARNING: the longest CI job test_features_3 took 3.89h
  • are-we-fast-r suite regressed by 0.96
  • simple suite improved by 1.03
  • Bounce_nonames regressed by 0.85
  • mandelbrot_naive_ascii regressed by 0.9
  • fasta regressed by 0.94
  • Overall benchmarks improved by 1.0

Please find your performance results at https://rir-benchmarks.prl.fit.cvut.cz/diff?job_ids[]=2443680603&job_ids[]=2427588749&selection=all

@o-
Copy link
Contributor

o- commented May 17, 2022

Here are some stats for your PR:

  • WARNING: the longest CI job test_features_1 took 2.66h
  • Overall benchmarks improved by 1.01

Please find your performance results at https://rir-benchmarks.prl.fit.cvut.cz/diff?job_ids[]=2468496070&job_ids[]=2467128976&selection=all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce unnecessary cloning of versions AND slow convergence to the optimal context
2 participants