-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCOCOA-2393 Add support for Xcode 16 #8618
Conversation
cf47c31
to
5b3de81
Compare
f124c9d
to
9108539
Compare
Needs a proper core release before this can be merged but I think the initial set of code changes are done and can be reviewed. |
Is there a rough ETA on this release? Xcode 16 has many things I'd like to try, but I can't use it until Realm is buildable there. |
You can build the framework from source and work against that until we've done an official release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!, Just some minor comments
RealmSwift/Realm.swift
Outdated
@@ -1356,6 +1356,35 @@ extension Realm { | |||
return Unchecked(ret) | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this be for swift less than 6, I'm a little bit confused because of the commit message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is moving the old version of the function into the #if compiler(<6)
block.
This test is relying on remaining on the main thread after an await.
Addresses some of #8628.