fix glms_sphere_transform by using mat4s instead of mat4 #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the struct version of the
gem_sphere_transform()
function does take avec4s
as the first parameter. Strangely enough the second parameter is not amat4s
as expected, but rather the normalmat4
.Because this is the only function in the whole
glms
-API, which takes a non-struct parameter, it has to be a mistake.