Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix glms_sphere_transform by using mat4s instead of mat4 #121

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

Zollerboy1
Copy link
Contributor

Currently the struct version of the gem_sphere_transform() function does take a vec4s as the first parameter. Strangely enough the second parameter is not a mat4s as expected, but rather the normal mat4.

Because this is the only function in the whole glms-API, which takes a non-struct parameter, it has to be a mistake.

@coveralls
Copy link

coveralls commented Mar 3, 2020

Coverage Status

Coverage remained the same at 65.317% when pulling b517d96 on Zollerboy1:master into b3a464b on recp:master.

@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files          65       65           
  Lines        5557     5557           
=======================================
  Hits         4805     4805           
  Misses        752      752

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 509071e...b517d96. Read the comment docs.

@recp recp merged commit 1f9765c into recp:master Mar 4, 2020
@recp
Copy link
Owner

recp commented Mar 4, 2020

@Zollerboy1 thanks for your contribution 🎉

@Zollerboy1
Copy link
Contributor Author

You’re welcome 😊
I’m currently building a Swift wrapper around cglm and without the struct-API this would be an absolute nightmare.

@recp
Copy link
Owner

recp commented Mar 4, 2020

Awesome !

I could use those wrappers for myself ;) You can also check cglm/applesimd.h header. I have created that header to translate cglm types to Apple SIMD library types to send cglm types to Metal GL without alignment issues. Apple/ObjC/Swift compatibility is very important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants