-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NarrowPublicClassMethodParamTypeRule: Take default value into account #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 14, 2024
tests/Rules/NarrowPublicClassMethodParamTypeRule/Fixture/SkipDefaultValue.php
Outdated
Show resolved
Hide resolved
staabm
commented
Jun 14, 2024
tests/Rules/NarrowPublicClassMethodParamTypeRule/Fixture/HandleDefaultValue.php
Show resolved
Hide resolved
staabm
commented
Jun 14, 2024
tests/Rules/NarrowPublicClassMethodParamTypeRule/Fixture/HandleDefaultValue.php
Show resolved
Hide resolved
staabm
changed the title
Added failling test
NarrowPublicClassMethodParamTypeRule: Take default value into account
Jun 14, 2024
found a fix |
samsonasik
reviewed
Jun 14, 2024
samsonasik
approved these changes
Jun 15, 2024
Thank you 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even if all calling types provide the same value, when a default value of a different type is used, the rule should not suggest to change the type.
in our case the default value is intentionally not a int, as we could otherwise not differentiate it from external calls.