Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NarrowPublicClassMethodParamTypeRule: Take default value into account #4

Merged
merged 7 commits into from
Jun 16, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jun 14, 2024

even if all calling types provide the same value, when a default value of a different type is used, the rule should not suggest to change the type.

in our case the default value is intentionally not a int, as we could otherwise not differentiate it from external calls.

@staabm staabm changed the title Added failling test NarrowPublicClassMethodParamTypeRule: Take default value into account Jun 14, 2024
@staabm
Copy link
Contributor Author

staabm commented Jun 14, 2024

found a fix

@TomasVotruba
Copy link
Member

Thank you 👏

@TomasVotruba TomasVotruba merged commit 4b2b573 into rectorphp:main Jun 16, 2024
6 checks passed
@staabm staabm deleted the skip-default branch September 18, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants