Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDR] Fix teardown failures during workload deletion #11382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sidhant-agrawal
Copy link
Contributor

@sidhant-agrawal sidhant-agrawal commented Feb 12, 2025

Fixes: #11377
Fixes: #11378

@sidhant-agrawal
Copy link
Contributor Author

Verified on ODF 4.18.0-124: https://url.corp.redhat.com/1a58042

@sidhant-agrawal sidhant-agrawal added the Verified Mark when PR was verified and log provided label Feb 13, 2025
@sidhant-agrawal sidhant-agrawal marked this pull request as ready for review February 13, 2025 18:14
@sidhant-agrawal sidhant-agrawal requested a review from a team as a code owner February 13, 2025 18:14
@sidhant-agrawal sidhant-agrawal requested a review from a team February 13, 2025 18:14
am-agrawa
am-agrawa previously approved these changes Feb 13, 2025
@openshift-ci openshift-ci bot added the lgtm label Feb 13, 2025
@openshift-ci openshift-ci bot removed the lgtm label Feb 21, 2025
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Feb 21, 2025
Copy link

openshift-ci bot commented Feb 21, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

openshift-ci bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…up and increase timeout for backend volume deletion

   - Introduced `workload_cleanup` parameter to differentiate final workload cleanup from resource deletion during DR action
   - Increased timeout in wait_for_backend_volume_deletion()

Signed-off-by: Sidhant Agrawal <[email protected]>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Feb 21, 2025
@sidhant-agrawal sidhant-agrawal changed the title Fix teardown failures due to temporary source PVCs not found [RDR] Fix teardown failures during workload deletion Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DR Metro and Regional DR related PRs size/M PR that changes 30-99 lines Squad/Turquoise Verified Mark when PR was verified and log provided
Projects
None yet
2 participants