Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vrg discovered app #11406

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Improve vrg discovered app #11406

wants to merge 8 commits into from

Conversation

prsurve
Copy link
Contributor

@prsurve prsurve commented Feb 14, 2025

No description provided.

@prsurve prsurve requested review from a team as code owners February 14, 2025 08:14
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Feb 14, 2025
am-agrawa
am-agrawa previously approved these changes Feb 14, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Feb 14, 2025
@openshift-ci openshift-ci bot removed the lgtm label Feb 14, 2025
@prsurve prsurve changed the title Improve vrg discovered app [DND] Improve vrg discovered app Feb 14, 2025
@prsurve prsurve changed the title [DND] Improve vrg discovered app [DNM] Improve vrg discovered app Feb 14, 2025
@prsurve
Improve getting vrg name for Discovered Apps
22d998c 
Signed-off-by: prsurve <[email protected]>
@prsurve
fix tox
885b741 
Signed-off-by: prsurve <[email protected]>
@prsurve
fix tox
7026d0c 
Signed-off-by: prsurve <[email protected]>
@prsurve
Pass vrg name
ea81587 
Signed-off-by: prsurve <[email protected]>
@prsurve prsurve force-pushed the improve_vrg_discovered_app branch from fcd4600 to ea81587 Compare February 17, 2025 18:12
@prsurve prsurve changed the title [DNM] Improve vrg discovered app Improve vrg discovered app Feb 18, 2025
@prsurve prsurve added the Verified Mark when PR was verified and log provided label Feb 18, 2025
@prsurve
Copy link
Contributor Author

prsurve commented Feb 18, 2025

Verification:- https://url.corp.redhat.com/b57b803

@prsurve
Copy link
Contributor Author

prsurve commented Feb 18, 2025

Verification managed apps:- https://url.corp.redhat.com/388be94

@prsurve
resolve comments
a288e7b 
Signed-off-by: prsurve <[email protected]>
@prsurve
resolve comments
0025e56 
Signed-off-by: prsurve <[email protected]>
am-agrawa
am-agrawa previously approved these changes Feb 18, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Feb 18, 2025
keemano
keemano previously approved these changes Feb 18, 2025
View reviewed changes
@prsurve prsurve dismissed stale reviews from keemano and am-agrawa via 1a874f1 February 18, 2025 18:55
@openshift-ci openshift-ci bot removed the lgtm label Feb 18, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 18, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidhant-agrawal sidhant-agrawal sidhant-agrawal left review comments

@am-agrawa am-agrawa am-agrawa left review comments

@keemano keemano keemano left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@am-agrawa am-agrawa

@keemano keemano

Labels
do-not-merge/hold size/M PR that changes 30-99 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prsurve @sidhant-agrawal @am-agrawa @keemano