Change the STS deployment tests to tier1 #11436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sagi Hirshfeld <[email protected]>
|
Labeling this is as Verified due to the minimal nature of the fix |
keesturam
approved these changes
Feb 18, 2025
DanielOsypenko
approved these changes
Feb 18, 2025
udaysk23
approved these changes
Feb 19, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, keesturam, sagihirshfeld, udaysk23, ypersky1980 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_sts_bucket_ops[AWS-STS-NEW] and test_sts_bucket_ops[AWS-STS-DEFAULT] have still not been tested in 4.18, even though many STS deployments have been automatically triggered.
The issue is that the vast majority (maybe all?) of the triggered STS-deployment-runs have been a tier1 run. Due to recent changes, I believe that we should increase the frequency of these two tests.