Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.18] Test bucket replication with versioning - minor refactor to existing test + advanced tests #11438

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sagihirshfeld
Copy link
Contributor

  • Add utility functions that deal with the comparison of object versions between two buckets
  • Generalize test_bucket_replication_with_versioning to support multiple pairs and make the original a test case the case for bucket_pairs_amount==1 (test_bucket_replication_with_versioning --> test_bucket_replication_with_versioning[single_bucket_pair])
  • Add test_bucket_replication_with_versioning[multiple_bucket_pairs]
  • Add test_bidirectional_replication_with_versioning
  • Add test_bucket_replication_with_versioning_suspension

@sagihirshfeld sagihirshfeld added Needs Testing Run tests and provide logs link MCG Multi Cloud Gateway / NooBaa related issues Squad/Red labels Feb 18, 2025
@sagihirshfeld sagihirshfeld self-assigned this Feb 18, 2025
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Feb 18, 2025
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm27
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_replication_with_versioning.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm27
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_replication_with_versioning.py::TestReplicationWithVersioning::test_bucket_replication_with_versioning_suspension
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: shirshfe-418ibm27
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_replication_with_versioning.py::TestReplicationWithVersioning::test_bucket_replication_with_versioning_suspension
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@sagihirshfeld
Copy link
Contributor Author

test_bucket_replication_with_versioning and test_bidirectional_replication_with_versioning passed in the first validation job, and test_bucket_replication_with_versioning_suspension passed at the third validation job after a few adjustments.

Setting the Verified label.

@sagihirshfeld sagihirshfeld added Verified Mark when PR was verified and log provided and removed Needs Testing Run tests and provide logs link labels Feb 19, 2025
@sagihirshfeld sagihirshfeld marked this pull request as ready for review February 19, 2025 13:56
@sagihirshfeld sagihirshfeld requested review from a team as code owners February 19, 2025 13:56
Copy link
Contributor

@ypersky1980 ypersky1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Returns:
list(Bucket): The created buckets
"""
# Using the OC interface allows patching a repli policy on the OBC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a repli policy? is it a typo and should be replaces with "replication"?

Copy link

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sagihirshfeld, ypersky1980

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm MCG Multi Cloud Gateway / NooBaa related issues size/L PR that changes 100-499 lines Squad/Red Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants