-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.18] Test bucket replication with versioning - minor refactor to existing test + advanced tests #11438
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sagi Hirshfeld <[email protected]>
8fc1d7a
to
922f64b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: shirshfe-418ibm27
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_replication_with_versioning.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: Sagi Hirshfeld <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: shirshfe-418ibm27
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_replication_with_versioning.py::TestReplicationWithVersioning::test_bucket_replication_with_versioning_suspension
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Job UNSTABLE (some or all tests failed).
…on issue Signed-off-by: Sagi Hirshfeld <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: shirshfe-418ibm27
Cluster Configuration: conf/deployment/ibmcloud/ipi_3az_rhcos_3m_3w.yaml
PR Test Suite:
PR Test Path: tests/functional/object/mcg/test_bucket_replication_with_versioning.py::TestReplicationWithVersioning::test_bucket_replication_with_versioning_suspension
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Setting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Returns: | ||
list(Bucket): The created buckets | ||
""" | ||
# Using the OC interface allows patching a repli policy on the OBC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a repli policy? is it a typo and should be replaces with "replication"?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sagihirshfeld, ypersky1980 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test_bucket_replication_with_versioning
to support multiple pairs and make the original a test case the case forbucket_pairs_amount==1
(test_bucket_replication_with_versioning
-->test_bucket_replication_with_versioning[single_bucket_pair]
)test_bucket_replication_with_versioning[multiple_bucket_pairs]
test_bidirectional_replication_with_versioning
test_bucket_replication_with_versioning_suspension