Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] exclude NOOBAA_PSQL_12_IMAGE for image verification after upgrade #11446

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

vavuthu
Copy link
Contributor

@vavuthu vavuthu commented Feb 20, 2025

cherry-pick of #10723

Signed-off-by: vavuthu [email protected]

@vavuthu vavuthu requested a review from a team as a code owner February 20, 2025 08:21
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Feb 20, 2025
@vavuthu vavuthu added team/ecosystem Ecosystem team related issues/PRs cherry-pick This is cherry-pick (backport) labels Feb 20, 2025
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, petr-balogh, shylesh, vavuthu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clacroix12
Copy link
Contributor

Verified: https://url.corp.redhat.com/40b094b

@clacroix12 clacroix12 added the Verified Mark when PR was verified and log provided label Feb 20, 2025
@clacroix12 clacroix12 merged commit cfac99c into red-hat-storage:release-4.15 Feb 20, 2025
6 of 7 checks passed
@petr-balogh
Copy link
Member

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@petr-balogh: #11446 failed to apply on top of branch "release-4.16":

Applying: exclude NOOBAA_PSQL_12_IMAGE for image verification after upgrade
Using index info to reconstruct a base tree...
M	ocs_ci/ocs/constants.py
M	ocs_ci/ocs/ocp.py
M	ocs_ci/ocs/ocs_upgrade.py
M	ocs_ci/ocs/resources/pod.py
M	ocs_ci/ocs/utils.py
Falling back to patching base and 3-way merge...
Auto-merging ocs_ci/ocs/utils.py
CONFLICT (content): Merge conflict in ocs_ci/ocs/utils.py
Auto-merging ocs_ci/ocs/resources/pod.py
Auto-merging ocs_ci/ocs/ocs_upgrade.py
CONFLICT (content): Merge conflict in ocs_ci/ocs/ocs_upgrade.py
Auto-merging ocs_ci/ocs/ocp.py
Auto-merging ocs_ci/ocs/constants.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 exclude NOOBAA_PSQL_12_IMAGE for image verification after upgrade

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vavuthu
Copy link
Contributor Author

vavuthu commented Feb 21, 2025

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@vavuthu: #11446 failed to apply on top of branch "release-4.17":

Applying: exclude NOOBAA_PSQL_12_IMAGE for image verification after upgrade
Using index info to reconstruct a base tree...
M	ocs_ci/ocs/constants.py
M	ocs_ci/ocs/ocp.py
M	ocs_ci/ocs/ocs_upgrade.py
M	ocs_ci/ocs/resources/pod.py
M	ocs_ci/ocs/utils.py
Falling back to patching base and 3-way merge...
Auto-merging ocs_ci/ocs/utils.py
CONFLICT (content): Merge conflict in ocs_ci/ocs/utils.py
Auto-merging ocs_ci/ocs/resources/pod.py
Auto-merging ocs_ci/ocs/ocs_upgrade.py
CONFLICT (content): Merge conflict in ocs_ci/ocs/ocs_upgrade.py
Auto-merging ocs_ci/ocs/ocp.py
Auto-merging ocs_ci/ocs/constants.py
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 exclude NOOBAA_PSQL_12_IMAGE for image verification after upgrade

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick This is cherry-pick (backport) lgtm size/M PR that changes 30-99 lines team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants