Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Modify Default Producer Compression Type #1511

Conversation

real-mday
Copy link

@real-mday real-mday commented Nov 12, 2024

Adding ability to configure default producer compression type (related to #1405)

Example usage:

kind: ConfigMap
metadata:
  name: redpanda-console
  labels:
    app.kubernetes.io/name: console
    app.kubernetes.io/instance: redpanda-console
    app.kubernetes.io/version: v2.7.2
data:
  config.yaml: |
    # from .Values.console.config
    connect:
      enabled: false
    kafka:
      brokers:
      - broker1:9092
      - broker2:9092
      - broker3:9092
      producerCompressionType: 
        value: "uncompressed"
      schemaRegistry:
        enabled: false

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2024

CLA assistant check
All committers have signed the CLA.

@real-mday real-mday force-pushed the Set-default-compression-type-and-reuse-old-messages-1405 branch from e4b3f2e to 5f1e16a Compare November 12, 2024 15:03
@weeco
Copy link
Contributor

weeco commented Nov 15, 2024

The compression type config should only be stored in the frontend settings, so that the selection is persisted there. I think the endpoint & config addition is some extra complexity we should omit for a niche usability feature.

@real-mday
Copy link
Author

#1405

Am I understanding correctly that although the issue is called "Set default compression type & reuse old messages" that you are only accepting features that implement "reuse old messages"? I can open a second PR which only addresses that but also maybe good to change the name of the issue

@weeco
Copy link
Contributor

weeco commented Nov 18, 2024

Now, but the issue was about saving the last selected compression type as a frontend setting. This PR introduces a new config in the backend + the setting is retrieved via an API endpoint. What could be done instead is to make it a config in the frontend and store it in a local state. This way the last selected compression type is stored (per user) and won't fallback to "Default"

@weeco weeco closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants