Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: fix topic name fields to comply with API standards #1624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bojand
Copy link
Member

@bojand bojand commented Feb 23, 2025

This PR addresses a few instances where we use name as a topic name, and changes it to topic_name as per our API standards.

There are a handful of other cases where name literal is used, but it is within a Topic message or similar, so I left those as is... But I am open to changing them.

There are other instances of name being used for resource names, such as user, or role, transform, or connector.... I did not touch those... Should we change those? This is probably our opportunity.

@bojand bojand requested review from sago2k8 and weeco February 23, 2025 19:05
@bojand bojand marked this pull request as ready for review February 23, 2025 19:05
Copy link

github-actions bot commented Feb 23, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedFeb 23, 2025, 7:06 PM

@weeco
Copy link
Contributor

weeco commented Feb 24, 2025

In my opinion using name for obvious cases such as a message already named after this specific resource seems fine. In this PR's case (cloud storage) I agree we should rename it to topic_name, good spot and indeed a good opportunity to ensure consistent naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants