CORE-8695 crash_tracker: implement crash report upload markers #25130
+138
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement marking crash reports as uploaded and checking if a crash report has been uploaded. This is implemented using empty files created on disk with the same name as the crash report + a ".uploaded" suffix.
Clean up any upload markers on disk that do not have an associated crash report. This cleanup is done after the count-based removal of crash reports (see remove_old_crashfiles()).
dotnwat
reviewed
Feb 23, 2025
Comment on lines
+40
to
+41
| return crash_report_path.parent_path() | ||
| / (crash_report_path.filename().string() + recorder::upload_marker_suffix); |
There was a problem hiding this comment.
is this different than return path + suffix?
|
|
||
| // Create an empty upload marker | ||
| const auto marker_path = to_upload_marker_path(file_path).string(); | ||
| auto f = co_await ss::open_file_dma(marker_path, ss::open_flags::create); |
There was a problem hiding this comment.
nit: without O_EXCL i'd expect this to succeed even if the file exists. So you could probably drop the is_uploaded() checked, unless there is something i'm missing.
| } | ||
|
|
||
| for (const auto& entry : | ||
| std::filesystem::directory_iterator(crash_report_dir)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will use empty files to track if a certain crash file has been uploaded through our metrics reporter telemetry mechanism.
To mark a crash file as uploaded, we touch a new file with the same name + the ".uploaded" suffix. To check if a crash file has been uploaded, we check if a file with the same name + the ".uploaded" suffix exists. We also implement the clean up of any upload markers on disk that do not have an associated crash report.
Fixes https://redpandadata.atlassian.net/browse/CORE-8695
Backports Required
Release Notes