[CORE-8760] rptest: fix race-y checks in test_index_recovery_after_upgrade
#25131
+129
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI test resultstest results on build#62107
test results on build#62115
test results on build#62124
test results on build#62138
test results on build#62144
test results on build#62152
test results on build#62157
test results on build#62167
|
|
Still flakey. Hmm. |
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
2 times, most recently
from
ef46591 to
854b56a
Compare
|
Force push to:
|
|
/ci-repeat 2 |
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
from
854b56a to
3874470
Compare
Retry command for Build#62138please wait until all jobs are finished before running the slash command |
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
from
3874470 to
969ef98
Compare
|
/ci-repeat 2 |
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
from
969ef98 to
a733f2f
Compare
dotnwat
reviewed
Feb 23, 2025
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
2 times, most recently
from
cfe1c1f to
6665122
Compare
|
/ci-repeat 5 |
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
from
6665122 to
decc991
Compare
Parses the compaction footer from a compacted index for a segment. This function implements logic similar to that found in `compacted_index_chunk_reader::load_footer()` to properly read compacted index footers for either V1 or V2/V3.
This test can race with segment rolls and un-self-compacted segments, since self compaction may not occur before `redpanda` version changes and node restarts occur. Thus, breaking the expectations around the compacted index `mtime()` stats. To fix the race conditions, use the newly added compaction index footer reader from `compute_storage.py` to check if a segment has been self compacted or not.
WillemKauf
force-pushed
the
compaction_recovery_upgrade_test_fix
branch
from
decc991 to
376fb6d
Compare
|
Force push to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test can race with segment rolls and un-self-compacted segments, since self compaction may not occur before
redpandaversion changes and node restarts occur. Thus, breaking the expectations around the compacted indexmtime()stats.To fix the race conditions, use a newly added compaction index footer reader from
compute_storage.pyto check if a segment has been self compacted or not, conditionally adding the segment to the list of expectedmtimevalues.Backports Required
Release Notes