-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] datalake/coordinator: consider cluster UUID to deduplicate files #25139
Open
andrwng
wants to merge
4
commits into
redpanda-data:dev
Choose a base branch
from
andrwng:dl-coordinator-cluster-uuid
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have an upcoming change to use cluster UUIDs in the file committer. This gets the initial plumbing out of the way.
I have an upcoming test where it'd be nice to operate directly on table metadata, to write a table that production Redpanda wouldn't write. To that end, this adds a method to rewrite a given table with a given metadata.
A subsequent commit will add a test that could benefit from counting the number of data files.
The commit offset metadata is used to deduplicate files that have already committed to the Iceberg catalog. The offset stored in this metadata is tied to the control topic partition whose coordinator wrote the snapshot. Following a cluster restore, the committed offset is no longer meaningful because the control topic and its offsets are not restored in the new cluster. This commit adds a cluster UUID to the metadata so we can differentiate metadata written from a different cluster.
Retry command for Build#62125please wait until all jobs are finished before running the slash command
|
CI test resultstest results on build#62125
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: whole cluster restore test
Backports Required
Release Notes