k/server/tests: reset leaders table on restart #25141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate code.
It seems that we keep running with old leaders table after restart otherwise and wait_for_controller_leadership succeeds before a leader is elected in the new post-restart term. Noticed this because test_topic_recreation_recovery keeps failing locally for me.
CI test resultstest results on build#62133
|
dotnwat
reviewed
Feb 23, 2025
Comment on lines
-126
to
-136
| void restart() { | ||
| shutdown(); | ||
| app_signal = std::make_unique<::stop_signal>(); | ||
| ss::smp::invoke_on_all([] { | ||
| auto& config = config::shard_local_cfg(); | ||
| config.get("disable_metrics").set_value(false); | ||
| }).get(); | ||
| app.initialize(proxy_config(), proxy_client_config()); | ||
| app.check_environment(); | ||
| app.wire_up_and_start(*app_signal, true); | ||
| } |
| @@ -280,6 +280,9 @@ class redpanda_thread_fixture { | |||
| app.initialize(proxy_config(), proxy_client_config()); | |||
| app.check_environment(); | |||
| app.wire_up_and_start(*app_signal, true); | |||
| app.controller->get_partition_leaders() | |||
| .invoke_on_all([](cluster::partition_leaders_table& t) { t.reset(); }) | |||
There was a problem hiding this comment.
makes sense to me. the c++ fixture is so fragile :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes