Removed excess /posts/ part from blog-posts resources and fixed localization bug. #463
Conversation
|
@bricesanchez I'm happy with this, how about you? |
| @@ -1,7 +1,9 @@ | |||
| Refinery::Core::Engine.routes.draw do | |||
| namespace :blog, :path => Refinery::Blog.page_url do | |||
| root :to => "posts#index" | |||
| resources :posts, :only => [:show] | |||
| resources :posts, path: '', :only => [:show] do | |||
There was a problem hiding this comment.
That's a breaking change. We should do a redirect from blog/posts/1 to blog/1.
There was a problem hiding this comment.
Why not? What is the point of this 'posts' level of url? And what redirect are you talking about (what action)?
There was a problem hiding this comment.
Was something like:
http://localhost:3000/blog/posts/blog-post-name
Now it is:
http://localhost:3000/blog/blog-post-name
If I've an existing blog indexed on google, all indexed posts will now point to a 404.
I suggest to add a permanent redirect from blog/posts/* to blog/*` in order to keep SEO index fine.
There was a problem hiding this comment.
May be
get "posts/:id", to: :show, on: :collection
is better?
There was a problem hiding this comment.
Actually, I don't know what I was thinking. What's wrong with /blog/posts/:id and /blog/posts ?
There was a problem hiding this comment.
I'm ok if we want to use blog urls without posts level but i would also like to add a redirect to be backward compatible with old urls
There was a problem hiding this comment.
@parndt, such url structure (without posts) even appers in this routes set in https://github.com/refinery/refinerycms-blog/blob/master/config/routes.rb#L8 , when you are trying to create the comment to post with invalid fields, you get failed validations and now see the url like 'http://example.com/blog/post-1/comment'. If you try to refresh the page, you will get 404 error. But as for me, this structure is perfect, and 'posts' is unnecessary (even non-friendly) part here, because 'blog' plays the role of 'posts' in this case.
Actually, the same (path: ' ') done in Refinery's extenstions generator, https://github.com/refinery/refinerycms/blob/master/core/lib/generators/refinery/engine/templates/config/routes.rb.erb#L5 , because there is no sense in urls like 'example.com/events/events/1',
| @@ -3,6 +3,7 @@ | |||
| root :to => "posts#index" | |||
| resources :posts, path: '', :only => [:show] do | |||
| get 'comments', on: :member, to: :show | |||
| get 'posts/:id(/comments)', on: :collection, to: redirect("#{Refinery::Blog.page_url}/%{id}") | |||
There was a problem hiding this comment.
This way there will be the 301 redirect if someone tries to get the post from old uri
This is extended PR (included #462). With fix of localization bug.