re-enable oversampling on PolarizedQProbe #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refl1d.probe.PolarizedQProbe
inherits fromPolarizedNeutronProbe
, but does not handle the inheritedoversampling
oroversampling_seed
kwargs in the init, so deserialization is currently broken.This PR adds these argument to the
PolarizedQProbe.__init__
, and calls the base classoversample(oversampling, oversampling_seed)
method during initialization, properly oversampling all the xs.This fixes the bug on deserialization, and also enables users of the class to take advantage of oversampling if it helps them in their fits.