Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable oversampling on PolarizedQProbe #214

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

bmaranville
Copy link
Member

refl1d.probe.PolarizedQProbe inherits from PolarizedNeutronProbe, but does not handle the inherited oversampling or oversampling_seed kwargs in the init, so deserialization is currently broken.

This PR adds these argument to the PolarizedQProbe.__init__, and calls the base class oversample(oversampling, oversampling_seed) method during initialization, properly oversampling all the xs.

This fixes the bug on deserialization, and also enables users of the class to take advantage of oversampling if it helps them in their fits.

@bmaranville
Copy link
Member Author

This is a very targeted fix to an active bug affecting users, and is unlikely to have effects outside the scope of PolarizedQProbe, so merging without further review so it can be released.

@bmaranville bmaranville merged commit d010f72 into master Oct 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant