Fix memory leaks with undici introduction (#249)

* Turn single fetch back on

* Fetch only HEAD in resources.server

* Consume all fetch bodies

app/lib/conf2023.server.ts

@@ -61,6 +61,8 @@ export async function getSpeakers(
     },
   });
   if (!fetched.ok) {
+    // Need to consume for undici since it won't garbage collect
+    await fetched.text();
     throw new Error(
       "Error fetching speakers, responded with status: " + fetched.status,
     );
@@ -124,6 +126,8 @@ export async function getConfSessions(
     },
   });
   if (!fetched.ok) {
+    // Need to consume for undici since it won't garbage collect
+    await fetched.text();
     throw new Error(
       "Error fetching speakers, responded with status: " + fetched.status,
     );
@@ -187,6 +191,8 @@ export async function getSchedules(
     getSpeakers(),
   ]);
   if (!fetched.ok) {
+    // Need to consume for undici since it won't garbage collect
+    await fetched.text();
     throw new Error(
       "Error fetching schedule, responded with status: " + fetched.status,
     );
@@ -460,6 +466,8 @@ async function fetchNaiveStaleWhileRevalidate(
     throw err;
   }
   if (res.status === 504) {
+    // Need to consume for undici since it won't garbage collect
+    await res.text();
     return fetchWithForceCache();
   }
 

app/lib/gh-docs/repo-content.ts

@@ -22,7 +22,11 @@ export async function getRepoContent(
     new URL(pathname, "https://raw.githubusercontent.com/").href,
     { headers: { "User-Agent": `docs:${owner}/${repo}` } },
   );
-  if (!response.ok) return null;
+  if (!response.ok) {
+    // Need to consume for undici since it won't garbage collect
+    await response.text();
+    return null;
+  }
   return response.text();
 }
 

app/lib/resources.server/index.ts

@@ -164,7 +164,9 @@ async function getSponsorUrl(owner: string) {
   let sponsorUrl = `${GITHUB_URL}/sponsors/${owner}`;
 
   try {
-    let response = await fetch(sponsorUrl);
+    // We don't need the body, just need to know if it's redirected
+    // method: "HEAD" removes the need for garbage collection: https://github.com/nodejs/undici?tab=readme-ov-file#garbage-collection
+    let response = await fetch(sponsorUrl, { method: "HEAD" });
     return !response.redirected ? sponsorUrl : undefined;
   } catch (e) {
     console.error("Failed to fetch sponsor url for", owner);

vite.config.mts

@@ -16,7 +16,7 @@ export default defineConfig({
     arraybuffer(),
     remix({
       future: {
-        unstable_singleFetch: false,
+        unstable_singleFetch: true,
       },
     }),
   ],