-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node 20 to test matrix #2133
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nodemon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit 32807b5
I don't think the tests are failing because of node 20 - but because something's either wrong in the test or there's a regression somewhere… I'm trying to have a look but don't have a lot of time (on the computer) atm - but if no one else does, I will do and I will get node 20 in the matrix. |
How would you feel about just testing only the latest 3 versions? 16, 18, 20? and setting minium node version to it as well in package.json |
Why are you arbitrarily proposing to drop support for 10 and 12? (This is rhetorical actually and rather it's naive to assume that I'd want that) |
On reflection, it would be ideal to only run integration tests on the lowest common node version, rather than the latest with all the bells. |
If that's the case your correct |
No description provided.