chore: bump chokidar to v4 #2235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chokidar v4 removed a bunch of its dependencies. Implicit dependecies, such as braces, have critical issues. braces's issue is particular is Uncontrolled resource consumption Updating Chokidar implicitly changes the requirement of supported node to >=14.16.0 since it is a requirement of its dependency: readdirp
✅ Deploy Preview for nodemon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@remy When you have a spare moment, curious if you have any thoughts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chokidar v4 removed a bunch of its dependencies.
Implicit dependecies, such as braces, have critical issues.
This issue was brought to my attention from Dependabot in my project and is the reason I am proposing this change.
Most notable is that Chokidar v4 reduced its dependencies from 13 to 1.
Updating Chokidar implicitly changes the requirement of supported node to >=14.16.0 since it is a requirement of Chokidar's now only dependency:
Due to the minimum requirement of node being changed to 14.6, I believe that this change requires a nodemon major version bump. I will defer this decision and action to the repo maintainer.