Update to support Cake4 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the library to support Cake4.
Cake4 updates the interface for CacheEngine and changes
read/writetoget/setand allows more flexibility with specifying defaults.The new interface also adds
clearGroup(public function clearGroup(string $group): bool). I implementedclearGroupusing the naive method of just iterating overkeys ...from redis. The CakePHPRedisEngineimplements this by keeping a separate key for groups and incrementing it when clearing a group. I didn't see an easy way to do this without rewriting much of this engine, so I chose to keep the naive approach for now.