-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update application setup guide for deploio #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have some points
@@ -126,11 +126,21 @@ Commit and push your changes! :tada: | |||
|
|||
## Verify | |||
|
|||
Check that you see a green page in each app. | |||
|
|||
### Heroku |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check should be done also for deplo.io, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is also described in the ### Deploio
section. The difference is that the application urls are generated and can be retrieved using the nctl cli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace create_application_server.md
completely.
Also be consistent with the order. Afterwards good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this file? I'd like to end up with two files:
- run_on_heroku.md
- run_on_deploio.md
- You have a Deploio account. | ||
- You have installed the `renuo-cli` gem. | ||
- You have installed the `nctl` command. | ||
- You have logged in using `nctl`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You have logged in using `nctl`. | |
- You have logged in using `nctl auth login`. |
|
||
### Prerequisites for Deploio | ||
|
||
- You've [read about what Deploio is](https://docs.nine.ch/docs/deplo-io/getting-started-with-deploio). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will point to the user guide later. @oliveranthony17 can you please add yourself a go live task for the user guide?
@@ -16,10 +31,12 @@ class ApplicationController < ActionController::Base | |||
end | |||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this under Heroku.
ruby_on_rails/robots_txt.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously you mentioned Deploio first. Please be consistent with the order.
No description provided.