Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update application setup guide for deploio #386

Merged
merged 13 commits into from
Feb 15, 2025
Merged

Conversation

CuddlyBunion341
Copy link
Contributor

No description provided.

@CuddlyBunion341 CuddlyBunion341 self-assigned this Sep 30, 2024
@CuddlyBunion341 CuddlyBunion341 changed the title Update go live section for deploio Update application setup guide for deploio Sep 30, 2024
@CuddlyBunion341 CuddlyBunion341 marked this pull request as draft September 30, 2024 07:54
@CuddlyBunion341 CuddlyBunion341 marked this pull request as ready for review October 2, 2024 07:15
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have some points

@@ -126,11 +126,21 @@ Commit and push your changes! :tada:

## Verify

Check that you see a green page in each app.

### Heroku
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check should be done also for deplo.io, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is also described in the ### Deploio section. The difference is that the application urls are generated and can be retrieved using the nctl cli.

Copy link
Member

@schmijos schmijos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace create_application_server.md completely.
Also be consistent with the order. Afterwards good to merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this file? I'd like to end up with two files:

  • run_on_heroku.md
  • run_on_deploio.md

- You have a Deploio account.
- You have installed the `renuo-cli` gem.
- You have installed the `nctl` command.
- You have logged in using `nctl`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- You have logged in using `nctl`.
- You have logged in using `nctl auth login`.


### Prerequisites for Deploio

- You've [read about what Deploio is](https://docs.nine.ch/docs/deplo-io/getting-started-with-deploio).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will point to the user guide later. @oliveranthony17 can you please add yourself a go live task for the user guide?

@@ -16,10 +31,12 @@ class ApplicationController < ActionController::Base
end
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this under Heroku.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously you mentioned Deploio first. Please be consistent with the order.

@CuddlyBunion341 CuddlyBunion341 merged commit 62f6859 into main Feb 15, 2025
1 check passed
@CuddlyBunion341 CuddlyBunion341 deleted the feature/deploio branch February 15, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants