-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introducing: per-module checks #309
base: v2-main
Are you sure you want to change the base?
Conversation
c61de00
to
d0756ba
Compare
output=$(${nodejs-wrapped}/bin/node --version) | ||
if [ "$output" != "v${nodejs-wrapped.version}" ]; then | ||
echo "Node.js version mismatch: expected v${nodejs-wrapped.version}, got $output" | ||
exit 1 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test could've caught a bug in a previous release of v1!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will be very important when we enforce version pinning. Do not want to accidentally upgrade the version by upgrading a Nix channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you setup a way to run all module checks as a command that can be used in ci?
Why
we want the testing story to be a lot better for v2 than it was for v1
this testing system allows us to write completely hermetic checks inline with the rest of the module declarations, while also allowing us to test various combinations of modules
the system is very bare-bones but i expect it to grow as we define needs
What changed
check
function as an output tov2/default.nix
checks
optionTest plan
for now, can be tested like so:
note that passing in 0 enabled modules will result in an empty checks file
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)