Avoid incorrectly setting LD_LIBRARY_PATH #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airportyh
reviewed
Oct 16, 2024
|
When do we use the shell wrapper vs the binary wrapper? |
|
@airportyh only in |
ryantm
reviewed
Oct 16, 2024
Co-authored-by: Ryan Mulligan <[email protected]>
ryantm
approved these changes
Oct 16, 2024
blast-hardcheese
deleted the
dstewart/bug/python-wrapper-legacy-channel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When I split out the binary Python wrapper, I misread that
LD_LIBRARY_PATHshould be set in all cases, not just the legacy case.What changed
Increasing readability and addressing the underlying bug. Also removed the
REPLIT_RTLD_LOADER = "1"check as the flag has been rolled out and burned in, and is unlikely to get rolled back.Test plan
Attempt to fork and run one of the test cases supplied by support.
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)