Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gherkin to 32.0.0 #489

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update Gherkin to 32.0.0 #489

wants to merge 1 commit into from

Conversation

obligaron
Copy link
Contributor

🤔 What's changed?

Update Gherkin to 32.0.0 and fixed related breaking changes.

⚡️ What's your motivation?

Updating to the latest version and Gerhkin 32.0.0 contains performance improvements.
The new version improves the feature file generation time of the BigReqnrollProject from ~1262ms to ~1033ms (22% improvement) on my machine.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

Gherkin 32.0.0 contains some (minor) breaking changes that are easy to fix, but they are still breaking changes.
These breaking changes can also affect Reqnroll plugins, see for example failing SpecSyncPlugin tests.
How do we handle this?

📋 Checklist:

  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant