Improve tests to make the migration to NSubstitute easier #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove LegacyStepArgumentTypeConverterExtensions Add ArgumentHelpers Removed dead test code Remove some unused vars in the tests Fixed some spelling in comments
304NotModified
commented
Feb 26, 2025
| @@ -84,6 +85,7 @@ public class StepArgumentTransformationTests | |||
| private readonly Mock<IContextManager> contextManagerStub = new Mock<IContextManager>(); | |||
| private readonly Mock<IAsyncBindingInvoker> methodBindingInvokerStub = new Mock<IAsyncBindingInvoker>(); | |||
| private readonly List<IStepArgumentTransformationBinding> stepTransformations = new List<IStepArgumentTransformationBinding>(); | |||
| private readonly CultureInfo _enUSCulture = new CultureInfo("en-US", false); | |||
There was a problem hiding this comment.
FYI same pattern as in StepArgumentTypeConverterTest.cs
304NotModified
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Refactored the tests, but don't changed the behavior of the tests.
StepArgumentTypeConverterStub.Setup(LegacyStepArgumentTypeConverterExtensions.GetCanConvertMethodFilteris unclear/vagueNote, I used Resharper for most actions, e.g. inline method, inline variable etc.
⚡️ What's your motivation?
The POC with the migration to NSubstitute
#497 showed use that some parts where difficult to migration.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Do we add these changes to the changelog?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.