Change ReqnrollOutputHelper to use test output #504
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Changed ReqnrollOutputHelper to use test output instead of the tool output in
ITraceListener.In practice this means that the
->prefix is not added to this messages.⚡️ What's your motivation?
The
ITraceListener.WriteToolOutputwas intended to provide information that come from the tool (ie Reqnroll), not from the tests, so this was incorrect.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
How could it happen that we didn't notice this so far...
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.