Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ndarray #7157

Closed
emilk opened this issue Aug 12, 2024 · 0 comments · Fixed by #7358
Closed

Update ndarray #7157

emilk opened this issue Aug 12, 2024 · 0 comments · Fixed by #7358
Labels
dependencies concerning crates, pip packages etc good first issue Good for newcomers help wanted Extra attention is needed 🦀 Rust API Rust logging API

Comments

@emilk
Copy link
Member

emilk commented Aug 12, 2024

0.16 is out, with a bunch of deprecated functions

@emilk emilk added 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team good first issue Good for newcomers help wanted Extra attention is needed dependencies concerning crates, pip packages etc 🦀 Rust API Rust logging API and removed 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 12, 2024
emilk pushed a commit that referenced this issue Sep 20, 2024
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What
Fixes #7157. I also updated ndarray-rand (sorry if that should be
separate - it didn't appear to require any changes).

into_raw_vec() is now into_raw_vec_and_offset().0 (the offset is
ignored)

I wasn't sure whether an order (`RowMajor` vs. `ColumnMajor`) should be
specified in `into_shape_with_order()`. I ran through all the examples
and couldn't find one that actually used this code, so guidance here is
appreciated.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7358?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7358?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7358)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc good first issue Good for newcomers help wanted Extra attention is needed 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant