-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ndarray to 0.16 and ndarray-rand to 0.15 #7358
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Sep 5, 2024
benliepert
force-pushed
the
benliepert/update_ndarray
branch
from
September 6, 2024 22:29
2f4c619
to
7b125e8
Compare
benliepert
commented
Sep 6, 2024
benliepert
commented
Sep 6, 2024
emilk
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
emilk
added
🦀 Rust API
Rust logging API
dependencies
concerning crates, pip packages etc
include in changelog
labels
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #7157. I also updated ndarray-rand (sorry if that should be separate - it didn't appear to require any changes).
into_raw_vec() is now into_raw_vec_and_offset().0 (the offset is ignored)
I wasn't sure whether an order (
RowMajor
vs.ColumnMajor
) should be specified ininto_shape_with_order()
. I ran through all the examples and couldn't find one that actually used this code, so guidance here is appreciated.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.