Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new constants for 2D View Coordinates #6178

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Apr 30, 2024

What

View Coordinates aren't limited to 3D. Generate constants for 2D ViewCoordinates using the existing type and leaving the 3rd dimension Unused.

We might also consider setting the third coordinate for just force right-handed spaces, or always force Z-forward to make sense in the context of our depth offset concept.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 💬 discussion include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Apr 30, 2024
Copy link

Deployed docs

Commit Link
fa35387 https://landing-3fnpxalzi-rerun.vercel.app/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant