-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Space View and GPS Coordinates archetype (Mapbox/OSM support) #6561
base: main
Are you sure you want to change the base?
Conversation
Awesome work! Sorry if it's a noob question, but how do I check this out?
|
New rerun needs rust version 1.79 while you have only 1.76. Update your rust toolchain and try it again. |
Ah, needed to update the |
Few changes we discussed:
|
I talked this one over with some folks and the desire is to keep ViewCoordinates separate and somewhat dedicated to interpretation of camera-orientation, as distinct from data semantics. I'm going to put together a proposal for a new archetype, probably named something like CRS (CoordinateReferenceSystem). We can start with this somewhat dedicated to the mapping use-cases, but I think it could be helpful for other things like CAD import where it might be useful to carry context like unit-sizes. |
Here's my proposal for adding a very simple CRS type as an indicator: #6601 |
The new The current cargo tree:
In
|
What is left from what we discussed:
For 1, I'm open to your suggestions. Should the feature be enabled or disabled by default? Either way, how should the CI/CD integration work? Should we test all features by default or test combinations of features? |
a14d6ab
to
1b5568f
Compare
@tfoldi nice work! Excited to see it merged :) |
Extended the nuScenes example with MapView to have at least one example using the new view: nuscenes_mapview.mp4 |
would this support plotting a scatter of points across the map (instead of a single point/track) ? from the PR seems yes a la |
yes, it does support multiple points |
good to know ! curious if team/egui has evaluated integrating cesium -> its rendering pipeline for large set of N points may be faster |
What
Map Space View for GNSS/GPS data logged through new GPS Coordinates archetype.
rerun_mapview.mp4
re_space_view_map
crate for visualizingPoints3D
with gps coordinates.map_visualizer_system.rs
implements theVisualizerSystem
trait. It has only one meaningful function, that takes thePositions3D
components and turns intovec<MapEntry>
array along with optionalColor
andRadius
components. Thisvec<MapEntry>
is the only field of theMapVisualizerSystem
.map_space_view.rs
is where the magic happens. It useswalkers
slippy map implementation to show an OpenStreetMap or Mapbox map. On theselection_ui
you can change the map providers. To view Mapbox maps, you need to set mapbox tokens (you can get free tokens from Mapbox's site) and pass it via the env variable (MAPBOX_ACCESS_TOKEN
) or via the blueprintmap_windows.rs
is a small helper to show the zoom controls and acknowledgment on the UIs.MapProvider
component (enum with providers+styles), and aMapOptions
archetype.The logging of data is performed as follows:
The blueprint is defined as follows:
The PR is not perfect, but the view is usable.
Please review the changes and evaluate their potential utility for your needs. If you don't like, prefer not to merge just close it - no hard feelings.
To be discussed
f32
instead off64
. This makes it less precise than/NavSatFix
Checklist
To run all checks from
main
, comment on the PR with@rerun-bot full-check
.