-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python bindings for new dataframe APIs #7357
Conversation
ae4f3f5
to
056a443
Compare
abbe65b
to
85c100c
Compare
c8b7fa2
to
300e232
Compare
dd04745
to
6e35ed1
Compare
rerun_py/src/dataframe.rs
Outdated
#[pyclass(frozen, name = "Schema")] | ||
#[derive(Clone)] | ||
pub struct PySchema { | ||
// TODO(jleibs): This gets replaced with the new schema object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess it doesn't after all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of feel like this goes away and these APIs move to the view? Punting that until after this PR either way.
620f82c
to
b23fc65
Compare
This PR added a dependency on
|
@@ -0,0 +1,5 @@ | |||
from __future__ import annotations | |||
|
|||
from typing import TYPE_CHECKING, TypeAlias, Union |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add these imports here?
I removed them in #7794
What
Example notebook for testing
Future work:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.